ci: Full revision of Goreleaser tasks #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ajnavarro |
sw360cab
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2672 +/- ##
==========================================
+ Coverage 60.11% 60.13% +0.01%
==========================================
Files 560 560
Lines 74918 74918
==========================================
+ Hits 45039 45049 +10
+ Misses 26504 26495 -9
+ Partials 3375 3374 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
How would we use this? |
zivkovicmilos
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Looks good 💯
Thank you for adding gnofaucet 🙏
Waiting on the final review from the release maestro @ajnavarro
ajnavarro
approved these changes
Aug 9, 2024
Check For tag release, it fallback to |
MikaelVallenet
pushed a commit
to MikaelVallenet/gno
that referenced
this pull request
Aug 17, 2024
This PR has different purposes: * adding Gnofaucet to Goreleaser task (closes gnolang#2557) * moving Goreleaser from v 1.26 to v 2.1 * reducing the verbosity of tasks by merging the different release types (latest, nightly, master) into a single goreleaser file * adding a fallbacked env variable called `TAG_VERSION`, which label the various docker images * adding the `nightly` subtask, which is ignored for latest releases * skipping publish for master release (NOTE: this part is the one TBC, because `master` release is using nightly too, but the variable `tag_name` unfortunately cannot be templated, let's see if it can make sense or if there is another workaround) <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
linhpn99
pushed a commit
to linhpn99/gno
that referenced
this pull request
Aug 20, 2024
This PR has different purposes: * adding Gnofaucet to Goreleaser task (closes gnolang#2557) * moving Goreleaser from v 1.26 to v 2.1 * reducing the verbosity of tasks by merging the different release types (latest, nightly, master) into a single goreleaser file * adding a fallbacked env variable called `TAG_VERSION`, which label the various docker images * adding the `nightly` subtask, which is ignored for latest releases * skipping publish for master release (NOTE: this part is the one TBC, because `master` release is using nightly too, but the variable `tag_name` unfortunately cannot be templated, let's see if it can make sense or if there is another workaround) <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has different purposes:
gnofaucet#2557)TAG_VERSION, which label the various docker imagesnightlysubtask, which is ignored for latest releasesmasterrelease is using nightly too, but the variabletag_nameunfortunately cannot be templated, let's see if it can make sense or if there is another workaround)Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description